lowka commented on code in PR #3714:
URL: https://github.com/apache/ignite-3/pull/3714#discussion_r1599553720
##########
modules/client/src/main/java/org/apache/ignite/internal/client/table/ClientKeyValueView.java:
##########
@@ -94,18 +97,24 @@ public class ClientKeyValueView<K, V> extends
AbstractClientView<Entry<K, V>> im
/** {@inheritDoc} */
@Override
public V get(@Nullable Transaction tx, K key) {
- return sync(getAsync(tx, key));
+ Objects.requireNonNull(key, "key");
+
+ return sync(doGet(tx, key, "getNullable"));
}
/** {@inheritDoc} */
@Override
public CompletableFuture<V> getAsync(@Nullable Transaction tx, K key) {
- Objects.requireNonNull(key);
+ Objects.requireNonNull(key, "key");
+
+ return doGet(tx, key, "getNullableAsync");
Review Comment:
No, it should not. It reports what method should be used instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
