denis-chudov commented on code in PR #3725:
URL: https://github.com/apache/ignite-3/pull/3725#discussion_r1599731099
##########
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/raft/MetaStorageWriteHandler.java:
##########
@@ -278,4 +309,50 @@ boolean beforeApply(Command command) {
return false;
}
+
+ private static class IdempotentCommandCache {
+ @Nullable
+ final Serializable result;
+
+ final HybridTimestamp commandStartTime;
Review Comment:
Why current time? Command start time is hybrid time. There is no sense to
make a conversion. And `long` type can create an ambiguity. `HybridTimestamp`
is more clear here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
