Vladsz83 commented on code in PR #11327:
URL: https://github.com/apache/ignite/pull/11327#discussion_r1603550374
##########
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java:
##########
@@ -6781,13 +6780,17 @@ else if (req.changeTopology()) {
"previous [" + previous + "] with
timeout " + backwardCheckTimeout);
}
- liveAddr = checkConnection(new
ArrayList<>(nodeAddrs), backwardCheckTimeout);
+ liveAddr = checkConnection(previous,
backwardCheckTimeout);
- if (log.isInfoEnabled()) {
- log.info("Connection check to previous
node done: [liveAddr=" + liveAddr
- + ", previousNode=" +
U.toShortString(previous) + ", addressesToCheck=" +
- nodeAddrs + ", connectingNodeId=" +
nodeId + ']');
- }
+ String logMsg = "Connection check to previous
node " + (liveAddr == null ? "failed" : "done")
+ + ". ConnectingNodeId=" + nodeId + ".
PreviousNode=" + U.toShortString(previous)
+ + ", firstAliveAddr=" + liveAddr + ",
addressesToCheck=" +
+ spi.getEffectiveNodeAddresses(previous) +
"].";
Review Comment:
Suggestion: we could move the log into checkConnection(..) and reuse already
called `spi.getEffectiveNodeAddresses(...)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
