valepakh commented on code in PR #3856:
URL: https://github.com/apache/ignite-3/pull/3856#discussion_r1622171796
##########
modules/api/src/main/java/org/apache/ignite/catalog/annotations/Zone.java:
##########
@@ -26,15 +25,22 @@
/**
* Describes a distribution zone.
*/
-@Target(TYPE)
+@Target({})
@Retention(RUNTIME)
public @interface Zone {
/**
* The name of the zone. If it's empty, the name of the class annotated
with this annotation will be used.
*
* @return The name of the zone.
*/
- String value() default "";
+ String value();
+
+ /**
+ * Storage profiles.
+ *
+ * @return Storage profiles.
+ */
+ String storageProfiles();
Review Comment:
Why did you moved this declaration?
##########
modules/catalog-dsl/src/integrationTest/java/org/apache/ignite/internal/catalog/ItCatalogDslTest.java:
##########
@@ -354,7 +353,6 @@ public int hashCode() {
@Table(
value = POJO_RECORD_TABLE_NAME,
- zone = ZoneTest.class,
Review Comment:
zone declaration missing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
