skorotkov commented on code in PR #271:
URL: https://github.com/apache/ignite-extensions/pull/271#discussion_r1622265660
##########
pom.xml:
##########
@@ -70,6 +69,15 @@
<module>../ignite</module>
</modules>
</profile>
+ <profile>
Review Comment:
I would suggest to not move the gatling-ext as a whole but the examples
sub-module only.
It's the examples sub-module who use the gatling-maven-plugin which is built
with jdk-11.
In other words modify the modules/gatling-ext/pom.xml moving the examples
to java-11+ profile as
```
<modules>
<module>gatling-plugin</module>
</modules>
<profiles>
<profile>
<id>java-11+</id>
<activation>
<jdk>[11,)</jdk>
</activation>
<modules>
<module>examples</module>
</modules>
</profile>
</profiles>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
