timoninmaxim commented on code in PR #276:
URL: https://github.com/apache/ignite-extensions/pull/276#discussion_r1637799733
##########
modules/cdc-ext/src/main/java/org/apache/ignite/cdc/kafka/KafkaToIgniteCdcStreamerApplier.java:
##########
@@ -107,6 +107,9 @@ class KafkaToIgniteCdcStreamerApplier implements Runnable,
AutoCloseable {
/** The maximum time to complete Kafka related requests, in milliseconds.
*/
private final long kafkaReqTimeout;
+ /** Consumer poll timeout. */
Review Comment:
Let's mention in javadocs (especially in public config) that the timeout is
measured in "milliseconds", in the same way it is for `kafkaReqTimeout`.
##########
modules/cdc-ext/src/test/java/org/apache/ignite/cdc/kafka/KafkaToIgniteLoaderTest.java:
##########
@@ -85,6 +93,35 @@ public void testLoadIgniteClientConfig() throws Exception {
assertNotNull(streamer);
}
+ @Test
Review Comment:
Missed javadoc for the test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
