korlov42 commented on code in PR #3904:
URL: https://github.com/apache/ignite-3/pull/3904#discussion_r1638254379
##########
modules/sql-engine/src/integrationTest/sql/cast/test_cast_bigint.test:
##########
@@ -0,0 +1,31 @@
+# name: test/sql/cast/test_cast_bigint.test
+# description: CAST BIGINT
+# feature: SQL F201(CAST function)
+# group: [cast]
+
+statement ok
+SELECT CAST('100' AS BIGINT);
Review Comment:
let's also add a few cases to cover conversion from exact numeric (like
DECIMAL or SMALLINT) and approximate numeric (like DOUBLE or REAL). The same
suggestion for rest of similar test cases
##########
modules/sql-engine/src/integrationTest/sql/cast/test_cast_interval_day.test:
##########
@@ -0,0 +1,144 @@
+# name: test/sql/cast/test_cast_interval_day.test
Review Comment:
let's add a few test cases for complex intervals (like DAYS TO MINUTES). The
same for YEAR-MONTH intervals
##########
modules/sql-engine/src/integrationTest/sql/cast/test_cast_bigint.test:
##########
@@ -0,0 +1,31 @@
+# name: test/sql/cast/test_cast_bigint.test
+# description: CAST BIGINT
+# feature: SQL F201(CAST function)
+# group: [cast]
+
+statement ok
+SELECT CAST('100' AS BIGINT);
Review Comment:
let's also add a few test cases for cast from interval types
##########
modules/sql-engine/src/integrationTest/sql/cast/test_cast_bigint.test:
##########
@@ -0,0 +1,31 @@
+# name: test/sql/cast/test_cast_bigint.test
+# description: CAST BIGINT
+# feature: SQL F201(CAST function)
+# group: [cast]
+
+statement ok
+SELECT CAST('100' AS BIGINT);
Review Comment:
let's check cast from string representing exponential notation
##########
modules/sql-engine/src/integrationTest/sql/cast/test_cast_bigint.test:
##########
@@ -0,0 +1,31 @@
+# name: test/sql/cast/test_cast_bigint.test
+# description: CAST BIGINT
+# feature: SQL F201(CAST function)
+# group: [cast]
+
+statement ok
+SELECT CAST('100' AS BIGINT);
Review Comment:
let's check cast from string '100.1'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
