tkalkirill commented on code in PR #3917:
URL: https://github.com/apache/ignite-3/pull/3917#discussion_r1639346269
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/index/IndexMetaStorage.java:
##########
@@ -154,78 +169,86 @@ Collection<IndexMeta> indexMetasSnapshot() {
return List.copyOf(indexMetaByIndexId.values());
}
- private void onCatalogIndexCreateEvent(CreateIndexEventParameters
parameters) {
+ private CompletableFuture<Boolean>
onCatalogIndexCreateEvent(CreateIndexEventParameters parameters) {
Review Comment:
The name may not be entirely obvious at first glance, but it has a certain
pattern, and is found in our project:
`on...Event` - says that this is a reaction to an event.
`Catalog` - indicates that this is a `CatalogEvent`.
`IndexCreate` - a specific event when an index is created in a catalog.
I don't see any need for documentation since the described name and argument
pattern self-documents the method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
