ptupitsyn commented on code in PR #3920:
URL: https://github.com/apache/ignite-3/pull/3920#discussion_r1642823033
##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/requests/table/ClientStreamerWithReceiverBatchSendRequest.java:
##########
@@ -102,7 +102,7 @@ public static CompletableFuture<Void> process(
private static class ReceiverRunnerJob implements ComputeJob<List<Object>>
{
@Override
- public @Nullable List<Object> execute(JobExecutionContext context,
Object... args) {
+ public CompletableFuture<List<Object>>
executeAsync(JobExecutionContext context, Object... args) {
Review Comment:
Fixed
##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/requests/table/ClientStreamerWithReceiverBatchSendRequest.java:
##########
@@ -115,7 +115,7 @@ private static class ReceiverRunnerJob implements
ComputeJob<List<Object>> {
CompletableFuture<List<Object>> receiveFut =
receiver.receive(receiverInfo.items(), receiverContext, receiverInfo.args());
- return receiveFut == null ? null : receiveFut.join();
+ return receiveFut == null ? nullCompletedFuture() : receiveFut;
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
