lowka commented on code in PR #3922:
URL: https://github.com/apache/ignite-3/pull/3922#discussion_r1644506331
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/exp/ExpressionFactoryImplTest.java:
##########
@@ -704,8 +701,36 @@ public void testRowSource() {
RexNode val10 = rexBuilder.makeExactLiteral(new BigDecimal("1"),
intType);
RexNode val11 = rexBuilder.makeExactLiteral(new BigDecimal("2"),
bigIntType);
Review Comment:
1. I think we need to ensure that DECIMAL values preserve precision/scale
after this transformation.
2. Ideally, we need to check literals of all types here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
