xtern commented on code in PR #3953:
URL: https://github.com/apache/ignite-3/pull/3953#discussion_r1650858858
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/SqlQueryProcessor.java:
##########
@@ -596,14 +624,22 @@ private CompletableFuture<AsyncSqlCursor<InternalSqlRow>>
queryScript(
) {
String schemaName = properties.get(QueryProperty.DEFAULT_SCHEMA);
ZoneId timeZoneId = properties.get(QueryProperty.TIME_ZONE_ID);
+ Long queryTimeout =
properties.getOrDefault(QueryProperty.QUERY_TIMEOUT, 0L);
+
+ Instant deadline;
+ if (queryTimeout != 0) {
+ deadline = Instant.now().plusMillis(queryTimeout);
Review Comment:
Personally, I would prefer to keep Instant. :thinking:
From my point of view, the code is cleaner this way. But let's discuss pros
and cons privately :sunglasses:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
