sanpwc commented on code in PR #3943: URL: https://github.com/apache/ignite-3/pull/3943#discussion_r1663654596
########## modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/rebalance/ZoneRebalanceRaftGroupEventsListener.java: ########## @@ -0,0 +1,615 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.distributionzones.rebalance; + +import static org.apache.ignite.internal.distributionzones.rebalance.DistributionZoneRebalanceEngineV2.calculateZoneAssignments; +import static org.apache.ignite.internal.distributionzones.rebalance.ZoneRebalanceUtil.pendingPartAssignmentsKey; +import static org.apache.ignite.internal.distributionzones.rebalance.ZoneRebalanceUtil.plannedPartAssignmentsKey; +import static org.apache.ignite.internal.distributionzones.rebalance.ZoneRebalanceUtil.stablePartAssignmentsKey; +import static org.apache.ignite.internal.distributionzones.rebalance.ZoneRebalanceUtil.switchAppendKey; +import static org.apache.ignite.internal.distributionzones.rebalance.ZoneRebalanceUtil.switchReduceKey; +import static org.apache.ignite.internal.distributionzones.rebalance.ZoneRebalanceUtil.union; +import static org.apache.ignite.internal.metastorage.dsl.Conditions.and; +import static org.apache.ignite.internal.metastorage.dsl.Conditions.notExists; +import static org.apache.ignite.internal.metastorage.dsl.Conditions.or; +import static org.apache.ignite.internal.metastorage.dsl.Conditions.revision; +import static org.apache.ignite.internal.metastorage.dsl.Conditions.value; +import static org.apache.ignite.internal.metastorage.dsl.Operations.ops; +import static org.apache.ignite.internal.metastorage.dsl.Operations.put; +import static org.apache.ignite.internal.metastorage.dsl.Operations.remove; +import static org.apache.ignite.internal.metastorage.dsl.Statements.iif; +import static org.apache.ignite.internal.util.CollectionUtils.difference; +import static org.apache.ignite.internal.util.CollectionUtils.intersect; +import static org.apache.ignite.internal.util.CompletableFutures.nullCompletedFuture; + +import java.util.Collection; +import java.util.HashSet; +import java.util.Map; +import java.util.Set; +import java.util.concurrent.CompletableFuture; +import java.util.concurrent.ExecutionException; +import java.util.concurrent.ScheduledExecutorService; +import java.util.concurrent.TimeUnit; +import java.util.concurrent.atomic.AtomicInteger; +import java.util.stream.Collectors; +import java.util.stream.Stream; +import org.apache.ignite.internal.affinity.AffinityUtils; +import org.apache.ignite.internal.affinity.Assignment; +import org.apache.ignite.internal.affinity.Assignments; +import org.apache.ignite.internal.catalog.CatalogService; +import org.apache.ignite.internal.distributionzones.DistributionZoneManager; +import org.apache.ignite.internal.lang.ByteArray; +import org.apache.ignite.internal.logger.IgniteLogger; +import org.apache.ignite.internal.logger.Loggers; +import org.apache.ignite.internal.metastorage.Entry; +import org.apache.ignite.internal.metastorage.MetaStorageManager; +import org.apache.ignite.internal.metastorage.WatchEvent; +import org.apache.ignite.internal.metastorage.dsl.Condition; +import org.apache.ignite.internal.metastorage.dsl.Iif; +import org.apache.ignite.internal.metastorage.dsl.SimpleCondition; +import org.apache.ignite.internal.metastorage.dsl.Update; +import org.apache.ignite.internal.raft.PeersAndLearners; +import org.apache.ignite.internal.raft.RaftError; +import org.apache.ignite.internal.raft.RaftGroupEventsListener; +import org.apache.ignite.internal.raft.Status; +import org.apache.ignite.internal.replicator.ZonePartitionId; +import org.apache.ignite.internal.util.ByteUtils; +import org.apache.ignite.internal.util.IgniteSpinBusyLock; + +/** + * Listener for the raft group events, which must provide correct error handling of rebalance process and start new rebalance after the + * current one finished. + */ +public class ZoneRebalanceRaftGroupEventsListener implements RaftGroupEventsListener { + /** Ignite logger. */ + private static final IgniteLogger LOG = Loggers.forClass(ZoneRebalanceRaftGroupEventsListener.class); + + /** Number of retrying of the current rebalance in case of errors. */ + private static final int REBALANCE_RETRY_THRESHOLD = 10; + + /** Delay between unsuccessful trial of a rebalance and a new trial, ms. */ + private static final int REBALANCE_RETRY_DELAY_MS = 200; + + /** Success code for the MetaStorage switch append assignments change. */ + private static final int SWITCH_APPEND_SUCCESS = 1; + + /** Success code for the MetaStorage switch reduce assignments change. */ + private static final int SWITCH_REDUCE_SUCCESS = 2; + + /** Success code for the MetaStorage pending rebalance change. */ + private static final int SCHEDULE_PENDING_REBALANCE_SUCCESS = 3; + + /** Success code for the MetaStorage stable assignments change. */ + private static final int FINISH_REBALANCE_SUCCESS = 4; Review Comment: > besides counters > also doesn't have counters logic Seems that it's the same. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
