sanpwc commented on code in PR #4038:
URL: https://github.com/apache/ignite-3/pull/4038#discussion_r1668757673
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -1877,12 +1874,12 @@ private CompletableFuture<Void>
handleChangePendingAssignmentEvent(
isRecovery
);
}), ioExecutor);
- } else {
+ } else if (pendingAssignmentsAreForced && localMemberAssignment !=
null) {
localServicesStartFuture = runAsync(() -> {
- if (pendingAssignmentsAreForced &&
replicaMgr.isReplicaStarted(replicaGrpId)) {
- replicaMgr.resetPeers(replicaGrpId,
fromAssignments(computedStableAssignments.nodes()));
- }
+ replicaMgr.resetPeers(replicaGrpId,
fromAssignments(computedStableAssignments.nodes()));
Review Comment:
BusyLock is missing.
I've added it while adding changes to the PartitionReplicaLifecycleManager.
Feel free to revert if you don't agree.
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -1835,9 +1834,7 @@ private CompletableFuture<Void>
handleChangePendingAssignmentEvent(
// In case of forced assignments we need to remove nodes that are
present in the stable set but are missing from the
// pending set. Such operation removes dead stable nodes from the
resulting stable set, which guarantees that we will
Review Comment:
I believe that comment should be changed, currently it seems misleading.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
