lowka commented on code in PR #4034:
URL: https://github.com/apache/ignite-3/pull/4034#discussion_r1669619160
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/IgniteTypeCoercion.java:
##########
@@ -547,6 +590,11 @@ RelDataType syncAttributes(
return null;
}
+ if ((SqlTypeUtil.isIntType(type1) && SqlTypeUtil.isCharacter(type2))
Review Comment:
This is not consistent with the following coercion rules used for columns
(see `AbstractTypeCoercion::commonTypeForBinaryComparison`):
> // 1 > '1' will be coerced to 1 > 1.
if (SqlTypeUtil.isAtomic(type1) && SqlTypeUtil.isCharacter(type2))
return type1;
> if (SqlTypeUtil.isAtomic(type2) && SqlTypeUtil.isCharacter(type1))
return type2
I think this if-clause is unnecessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
