sanpwc commented on code in PR #4070:
URL: https://github.com/apache/ignite-3/pull/4070#discussion_r1678854238
##########
modules/table/src/integrationTest/java/org/apache/ignite/internal/table/ItTransactionRecoveryTest.java:
##########
@@ -789,7 +791,8 @@ public void
testPrimaryFailureWhileInflightInProgressAfterFirstResponse() throws
cancelLease(commitPartNode, tblReplicationGrp);
- assertThat(commitFut,
willThrow(MismatchingTransactionOutcomeException.class, 30, SECONDS));
+ TransactionException txEx = assertWillThrow(commitFut,
TransactionException.class, 30, SECONDS);
+ assertThat(txEx.getCause(),
instanceOf(MismatchingTransactionOutcomeException.class));
Review Comment:
Same as above. MismatchingTransactionOutcomeException is a
TransactionException itself. There's no need to wrap it with any other
TransactionException. We may however move
MismatchingTransactionOutcomeException to public API. Same for
IncompatibleSchemaException etc.
Seems that the problem is deeper.
> How that should work. Almost all our exceptions extend either
IgniteExpception or IgniteCheckedException but placed in internal packages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
