tkalkirill commented on code in PR #4113:
URL: https://github.com/apache/ignite-3/pull/4113#discussion_r1684006386


##########
modules/raft/src/main/java/org/apache/ignite/raft/jraft/storage/impl/RocksDbSpillout.java:
##########
@@ -144,6 +144,7 @@ public RocksDbSpillout(
         this.groupEndBound = new Slice(groupEndPrefix);
 
         this.writeOptions = new WriteOptions();
+        this.writeOptions.setDisableWAL(true);

Review Comment:
   It was simply not obvious to me from the name of the class that it was for 
volatile tables and it was said in the documentation at the very end.
   Maybe I would rename the class to something like `RocksDbLogsNotSpillout`. 
   Or at least indicate in the title of the problem that it is about volatile 
raft groups.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to