xtern commented on code in PR #4114:
URL: https://github.com/apache/ignite-3/pull/4114#discussion_r1689650854
##########
modules/schema/src/test/java/org/apache/ignite/internal/schema/AbstractSchemaConverterTest.java:
##########
@@ -67,15 +66,13 @@ public class AbstractSchemaConverterTest extends
BaseIgniteAbstractTest {
tmp.put(NativeTypeSpec.DATETIME, Arrays.asList(null,
LocalDateTime.MIN, LocalDateTime.MAX, LocalDateTime.now()));
tmp.put(NativeTypeSpec.TIMESTAMP, Arrays.asList(null, Instant.MIN,
Instant.MAX, Instant.EPOCH, Instant.now()));
tmp.put(NativeTypeSpec.UUID, Arrays.asList(null, UUID.randomUUID()));
- tmp.put(NativeTypeSpec.BITMASK, Arrays.asList(null, fromBinString(""),
fromBinString("1"),
- fromBinString("10101010101010101010101")));
tmp.put(NativeTypeSpec.STRING, Arrays.asList(null, "",
UUID.randomUUID().toString()));
tmp.put(NativeTypeSpec.BYTES, Arrays.asList(null,
ArrayUtils.BYTE_EMPTY_ARRAY,
UUID.randomUUID().toString().getBytes(StandardCharsets.UTF_8)));
- tmp.put(NativeTypeSpec.NUMBER, Arrays.asList(null, BigInteger.ONE,
BigInteger.ZERO,
- new BigInteger("10000000000000000000000000000000000000")));
var missedTypes = new
HashSet<>(Arrays.asList(NativeTypeSpec.values()));
+ missedTypes.remove(NativeTypeSpec.NUMBER);
Review Comment:
:thinking: from my point of view all similar changes in tests must be
covered with TODO "the issue actually removing of native types"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
