ibessonov commented on code in PR #4131:
URL: https://github.com/apache/ignite-3/pull/4131#discussion_r1689823865
##########
modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/AbstractPageMemoryTableStorage.java:
##########
@@ -93,6 +93,9 @@ public StorageIndexDescriptorSupplier
getIndexDescriptorSupplier() {
*/
public abstract DataRegion<?> dataRegion();
+ /** Returns storage engine for the table. */
+ public abstract AbstractPageMemoryStorageEngine engine();
Review Comment:
`protected` maybe? Why would it be public.
Whatever you decide
##########
modules/storage-page-memory/src/test/java/org/apache/ignite/internal/storage/pagememory/mv/PersistentPageMemoryMvPartitionStorageConcurrencyTest.java:
##########
@@ -52,7 +52,7 @@ void setUp(
@InjectConfiguration("mock.checkpoint.checkpointDelayMillis = 0")
PersistentPageMemoryStorageEngineConfiguration engineConfig,
@InjectConfiguration("mock.profiles.default = {engine =
\"aipersist\"}")
- StorageConfiguration storageConfiguration
+ StorageConfiguration storageConfig
Review Comment:
It's strange that you've shortened this name. What motivated you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
