ptupitsyn commented on code in PR #4130:
URL: https://github.com/apache/ignite-3/pull/4130#discussion_r1695069033
##########
modules/platforms/dotnet/Apache.Ignite.Tests/FakeServer.cs:
##########
@@ -76,12 +78,15 @@ public FakeServer(bool disableOpsTracking, string nodeName
= "fake-server")
internal FakeServer(
Func<RequestContext, bool>? shouldDropConnection = null,
string nodeName = "fake-server",
- bool disableOpsTracking = false)
+ bool disableOpsTracking = false,
+ int port = 0)
+ : base(port)
{
_shouldDropConnection = shouldDropConnection ?? (_ => false);
- Node = new ClusterNode("id-" + nodeName, nodeName,
(IPEndPoint)Listener.LocalEndPoint!);
+ Node = new ClusterNode("id-" + nodeName, nodeName,
IPEndPoint.Parse("127.0.0.1:" + Port));
Review Comment:
Listener listens on `0.0.0.0` (all interfaces), but client connects to
`127.0.0.1`, this breaks assumptions in some tests. Easier to fix here once
than to fix multiple tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
