kgusakov commented on code in PR #4169:
URL: https://github.com/apache/ignite-3/pull/4169#discussion_r1701679070
##########
modules/metrics/src/main/java/org/apache/ignite/internal/metrics/MetricManagerImpl.java:
##########
@@ -195,9 +195,15 @@ private <T extends ExporterView> void
checkAndStartExporter(
MetricExporter<T> exporter = availableExporters.get(exporterName);
if (exporter != null) {
- exporter.start(metricsProvider, exporterConfiguration);
-
- enabledMetricExporters.put(exporter.name(), exporter);
+ enabledMetricExporters.computeIfAbsent(exporter.name(), name -> {
+ try {
+ exporter.start(metricsProvider, exporterConfiguration);
+ return exporter;
+ } catch (Exception e) {
+ log.warn("Unable to start metrics exporter name=[" +
exporterName + "].", e);
+ return null;
Review Comment:
empty line before?
##########
modules/metrics/src/main/java/org/apache/ignite/internal/metrics/MetricManagerImpl.java:
##########
@@ -195,9 +195,15 @@ private <T extends ExporterView> void
checkAndStartExporter(
MetricExporter<T> exporter = availableExporters.get(exporterName);
if (exporter != null) {
- exporter.start(metricsProvider, exporterConfiguration);
-
- enabledMetricExporters.put(exporter.name(), exporter);
+ enabledMetricExporters.computeIfAbsent(exporter.name(), name -> {
+ try {
+ exporter.start(metricsProvider, exporterConfiguration);
+ return exporter;
Review Comment:
empty line before?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
