denis-chudov commented on code in PR #4143:
URL: https://github.com/apache/ignite-3/pull/4143#discussion_r1701708803
##########
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/impl/MetaStorageServiceImpl.java:
##########
@@ -332,4 +349,19 @@ private RemoveAllCommand
removeAllCommand(MetaStorageCommandsFactory commandsFac
return
commandsFactory.removeAllCommand().keys(list).initiatorTime(ts).build();
}
+
+ /**
+ * Creates evict idempotent commands cache command.
+ *
+ * @param commandsFactory Commands factory.
+ * @param evictionTimestamp Cached entries older than given timestamp will
be evicted.
+ * @param ts Local time.
Review Comment:
but you swapped the parameters in the method signature, not javadoc, and
didn't change the usage...
The method is called with `evictionTimestamp` as 3rd parameter but in the
method it's 2nd
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
