isapego commented on code in PR #4182: URL: https://github.com/apache/ignite-3/pull/4182#discussion_r1705135214
########## modules/platforms/cpp/ignite/network/network.h: ########## @@ -38,4 +39,22 @@ std::unique_ptr<socket_client> make_tcp_socket_client(); */ std::shared_ptr<async_client_pool> make_async_client_pool(data_filters filters); +/** + * Ensure that SSL library is loaded. + * + * Called implicitly when secure_socket is created, so there is no need to call this function explicitly. + * + * @throw ignite_error if it is not possible to load SSL library. + */ +void ensure_ssl_loaded(); + +/** + * Make secure socket for SSL/TLS connection. + * + * @param cfg Configuration. + * + * @throw ignite_error if it is not possible to load SSL library. + */ +std::unique_ptr<socket_client> make_secure_socket_client(secure_configuration cfg); + Review Comment: No-no, this is non-public library. This is part of the lib API, but the lib is used inside the client, user does not use it directly. ########## modules/platforms/cpp/ignite/network/network.h: ########## @@ -38,4 +39,22 @@ std::unique_ptr<socket_client> make_tcp_socket_client(); */ std::shared_ptr<async_client_pool> make_async_client_pool(data_filters filters); +/** + * Ensure that SSL library is loaded. + * + * Called implicitly when secure_socket is created, so there is no need to call this function explicitly. + * + * @throw ignite_error if it is not possible to load SSL library. + */ +void ensure_ssl_loaded(); + +/** + * Make secure socket for SSL/TLS connection. + * + * @param cfg Configuration. + * + * @throw ignite_error if it is not possible to load SSL library. + */ +std::unique_ptr<socket_client> make_secure_socket_client(secure_configuration cfg); + Review Comment: No, this is non-public library. This is part of the lib API, but the lib is used inside the client, user does not use it directly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
