rpuch commented on code in PR #4186:
URL: https://github.com/apache/ignite-3/pull/4186#discussion_r1705602290
##########
modules/cluster-management/src/main/java/org/apache/ignite/internal/cluster/management/ClusterTag.java:
##########
@@ -45,7 +45,22 @@ public interface ClusterTag extends NetworkMessage,
Serializable {
* @param name Cluster name.
* @return Cluster tag instance.
*/
- static ClusterTag clusterTag(CmgMessagesFactory msgFactory, String name) {
+ static ClusterTag randomClusterTag(CmgMessagesFactory msgFactory, String
name) {
+ return msgFactory.clusterTag()
+ .clusterName(name)
+ .clusterId(UUID.randomUUID())
+ .build();
+ }
+
+ /**
+ * Creates a new cluster tag instance. Acts like a constructor replacement.
+ *
+ * @param msgFactory Message factory to instantiate builder.
+ * @param name Cluster name.
+ * @param clusterId Cluster ID.
+ * @return Cluster tag instance.
+ */
+ static ClusterTag clusterTag(CmgMessagesFactory msgFactory, String name,
UUID clusterId) {
return msgFactory.clusterTag()
.clusterName(name)
.clusterId(UUID.randomUUID())
Review Comment:
Good catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
