AMashenkov commented on code in PR #4180:
URL: https://github.com/apache/ignite-3/pull/4180#discussion_r1706731268
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/schema/SqlSchemaManagerImpl.java:
##########
@@ -236,20 +285,35 @@ private static TableDescriptor
createTableDescriptorForTable(CatalogTableDescrip
}
}
- List<Integer> colocationColumns =
descriptor.colocationColumns().stream()
- .map(columnToIndex::getInt)
- .collect(Collectors.toList());
-
// Add virtual column.
ColumnDescriptorImpl partVirtualColumn =
createPartitionVirtualColumn(columns.size());
colDescriptors.add(partVirtualColumn);
- columnToIndex.put(partVirtualColumn.name(),
partVirtualColumn.logicalIndex());
+
+ IgniteDistribution distribution = createDistribution(descriptor,
columnToIndex);
+
+ return new TableDescriptorImpl(colDescriptors, distribution);
+ }
+
+ private static IgniteDistribution
createDistribution(CatalogTableDescriptor descriptor, Object2IntMap<String>
columnToIndex) {
+ List<Integer> colocationColumns =
descriptor.colocationColumns().stream()
+ .map(columnToIndex::getInt)
+ .collect(Collectors.toList());
Review Comment:
I'd like to see here smth like
```
IntList colocationColumns =
IntArrayList.toList(descriptor.colocationColumns().stream()
.mapToInt(columnToIndex::getInt));
```
but it is out of scope.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
