rpuch commented on code in PR #4201:
URL: https://github.com/apache/ignite-3/pull/4201#discussion_r1707621144
##########
modules/storage-api/src/testFixtures/java/org/apache/ignite/internal/storage/BaseMvStoragesTest.java:
##########
@@ -72,7 +74,7 @@ public abstract class BaseMvStoragesTest extends
BaseIgniteAbstractTest {
= MARSHALLER_FACTORY.create(SCHEMA_DESCRIPTOR, TestKey.class,
TestValue.class);
/** Hybrid clock to generate timestamps. */
- protected final HybridClock clock = new HybridClockImpl();
+ protected static final HybridClock CLOCK = new HybridClockImpl();
Review Comment:
Why was this change introduced? Just to make it possible to make
`newTransactionId()` static? If yes, why does it need to be static?
##########
modules/schema/src/testFixtures/java/org/apache/ignite/internal/schema/BinaryRowMatcher.java:
##########
@@ -30,16 +29,25 @@ public class BinaryRowMatcher extends
CustomMatcher<BinaryRow> {
private final @Nullable BinaryRow row;
private BinaryRowMatcher(@Nullable BinaryRow row) {
- super("Expected row to be equal to " + rowToString(row));
+ super("a row equal to " + rowToString(row));
this.row = row;
}
+ @Override
+ public void describeMismatch(Object item, Description description) {
+ if (item instanceof BinaryRow) {
Review Comment:
Can this be a `TypeSafeMatcher` to avoid casting?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
