JAkutenshi commented on code in PR #4194:
URL: https://github.com/apache/ignite-3/pull/4194#discussion_r1713383822
##########
modules/table/src/testFixtures/java/org/apache/ignite/distributed/ItTxTestCluster.java:
##########
@@ -940,11 +906,25 @@ public void shutdownCluster() {
assertThat(clientTxManager.stopAsync(new ComponentContext()),
willCompleteSuccessfully());
}
- // TODO: should be removed in
https://issues.apache.org/jira/browse/IGNITE-22774
- for (Map.Entry<String, List<RaftGroupService>> e :
raftClients.entrySet()) {
- for (RaftGroupService svc : e.getValue()) {
- svc.shutdown();
+ Set<TablePartitionId> grpIds = tables.values()
+ .stream()
+ .map(table -> new TablePartitionId(table.tableId(), 0))
+ .collect(toSet());
+
+ for (String consistentId : clusterServices.keySet()) {
+ ReplicaManager replicaManager = replicaManagers.get(consistentId);
+
+ if (replicaManager == null) {
+ continue;
}
+
+ grpIds.forEach(id -> {
+ try {
+ replicaManager.stopReplica(id);
+ } catch (NodeStoppingException e) {
Review Comment:
I agree, but it's a stopping process for tests -- I'm not sure what should I
do in case `NSE` while a partial node is stopping?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
