alex-plekhanov commented on code in PR #11462:
URL: https://github.com/apache/ignite/pull/11462#discussion_r1713527952
##########
modules/core/src/main/java/org/apache/ignite/internal/client/thin/io/gridnioserver/GridNioClientConnectionMultiplexer.java:
##########
@@ -194,7 +195,7 @@ public
GridNioClientConnectionMultiplexer(ClientConfiguration cfg) {
return new GridNioClientConnection(ses, msgHnd, stateHnd);
}
catch (Exception e) {
- throw new ClientConnectionException(e.getMessage(), e);
+ throw new ClientConnectionException(e.getMessage() + " [" + addr +
']', e);
Review Comment:
`" [remoteAddress=" + addr`?
##########
modules/core/src/main/java/org/apache/ignite/internal/client/thin/io/gridnioserver/GridNioClientConnectionMultiplexer.java:
##########
@@ -43,6 +43,7 @@
import org.apache.ignite.internal.util.nio.GridNioServer;
import org.apache.ignite.internal.util.nio.GridNioSession;
import org.apache.ignite.internal.util.nio.ssl.GridNioSslFilter;
+import org.apache.ignite.internal.util.typedef.internal.S;
Review Comment:
Redundant import
##########
modules/core/src/test/java/org/apache/ignite/internal/client/thin/FunctionalTest.java:
##########
@@ -644,6 +645,8 @@ public void testClientFailsOnStart() {
String.format("%s expected but no exception was received",
ClientConnectionException.class.getName()),
expEx
);
+
+ assertContains(log, expEx.getMessage(), "[InetSocketAddress [holder="
+ Config.SERVER + "]]");
Review Comment:
This message was changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
