ptupitsyn commented on code in PR #4226:
URL: https://github.com/apache/ignite-3/pull/4226#discussion_r1715310921
##########
modules/client/src/main/java/org/apache/ignite/internal/client/ReliableChannel.java:
##########
@@ -143,21 +142,18 @@ public final class ReliableChannel implements
AutoCloseable {
/** {@inheritDoc} */
@Override
- public synchronized void close() throws Exception {
+ public synchronized void close() {
closed = true;
List<ClientChannelHolder> holders = channels;
- IgniteUtils.closeAllManually(
- () -> {
- if (holders != null) {
- for (ClientChannelHolder hld : holders) {
- hld.close();
- }
- }
- },
- connMgr::stop,
- () -> shutdownAndAwaitTermination(streamerFlushExecutor, 10,
TimeUnit.SECONDS));
+ if (holders != null) {
+ for (ClientChannelHolder hld : holders) {
+ hld.close();
+ }
+ }
+ connMgr.stop();
+ shutdownAndAwaitTermination(streamerFlushExecutor, 10,
TimeUnit.SECONDS);
Review Comment:
This is not the same as the old `closeAllManually` call - we should wrap
every `close()` in a try-catch so that everything is closed even if there was
an exception.
We should also do this for `holders`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
