AMashenkov commented on code in PR #4206:
URL: https://github.com/apache/ignite-3/pull/4206#discussion_r1716814218
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/ExecutionTargetProviderImpl.java:
##########
@@ -152,22 +162,45 @@ private CompletableFuture<TokenizedAssignments>
primaryReplica(
});
}
- private CompletableFuture<TokenizedAssignments> allReplicas(
- ReplicationGroupId replicationGroupId,
+ private CompletableFuture<List<TokenizedAssignments>> allReplicas(
+ List<TablePartitionId> replicationGroupIds,
HybridTimestamp operationTime
) {
- CompletableFuture<TokenizedAssignments> f =
placementDriver.getAssignments(
- replicationGroupId,
+ CompletableFuture<List<TokenizedAssignments>> f =
placementDriver.getAssignments(
+ replicationGroupIds,
operationTime
);
return f.thenCompose(assignments -> {
- if (assignments == null) {
- // assignments are not ready yet, let's fall back to primary
replicas
- return primaryReplica(replicationGroupId, operationTime);
+ // Collect missed assignments indexes if found.
+ IntList missedAssignments = new IntArrayList(0);
+
+ for (int i = 0; i < assignments.size(); i++) {
+ if (assignments.get(i) == null) {
+ missedAssignments.add(i);
+ }
+ }
+
+ if (missedAssignments.isEmpty()) {
+ return completedFuture(assignments);
}
- return completedFuture(assignments);
+ // assignments are not ready yet, let's fall back to primary
replicas
+ List<CompletableFuture<TokenizedAssignments>>
primaryReplicaAssignment = new ArrayList<>(missedAssignments.size());
+
+ for (int i = 0; i < missedAssignments.size(); i++) {
+
primaryReplicaAssignment.add(primaryReplica(replicationGroupIds.get(missedAssignments.getInt(i)),
operationTime));
+ }
+
+ CompletableFuture<Void> all =
CompletableFuture.allOf(primaryReplicaAssignment.toArray(new
CompletableFuture[0]));
+ return all.thenApply(ignore -> {
+ // Replace missed assignments with primary replicas.
+ for (int i = 0; i < missedAssignments.size(); i++) {
+ assignments.set(missedAssignments.getInt(i),
primaryReplicaAssignment.get(i).join());
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
