ibessonov commented on code in PR #4231:
URL: https://github.com/apache/ignite-3/pull/4231#discussion_r1718020069
##########
modules/storage-rocksdb/src/test/java/org/apache/ignite/internal/storage/rocksdb/RocksDbMvPartitionStorageTest.java:
##########
@@ -49,7 +49,7 @@ void setUp(
@WorkDirectory Path workDir,
@InjectConfiguration("mock.flushDelayMillis = 0")
RocksDbStorageEngineConfiguration engineConfig,
- @InjectConfiguration("mock.profiles.default = {engine = rocksdb,
size = 16777216, writeBufferSize = 16777216}")
+ @InjectConfiguration("mock.profiles.default = {engine = rocksdb,
size = 16777216, writeBufferSize = 67108864}")
Review Comment:
Small buffer size triggers flush on every write, I reduce log output here
##########
modules/raft/src/main/java/org/apache/ignite/internal/raft/util/SharedLogStorageFactoryUtils.java:
##########
@@ -33,10 +34,15 @@ public class SharedLogStorageFactoryUtils {
public static final String LOGIT_STORAGE_ENABLED_PROPERTY =
"LOGIT_STORAGE_ENABLED";
/** Creates a LogStorageFactory with the {@link DefaultLogStorageFactory}
implementation. */
+ @TestOnly
public static LogStorageFactory create(String nodeName, Path
lazyLogStoragePath) {
Review Comment:
Sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
