alex-plekhanov commented on code in PR #11480:
URL: https://github.com/apache/ignite/pull/11480#discussion_r1718426058
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/datastructures/DataStructuresProcessor.java:
##########
@@ -259,6 +259,7 @@ public DataStructuresProcessor(GridKernalContext ctx) {
/** {@inheritDoc} */
@Override public void start() {
ctx.event().addLocalEventListener(lsnr, EVT_NODE_LEFT,
EVT_NODE_FAILED);
+ ctx.internalSubscriptionProcessor().registerGlobalStateListener(this);
Review Comment:
Fixed
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/task/GridTaskProcessor.java:
##########
@@ -200,6 +200,8 @@ public GridTaskProcessor(GridKernalContext ctx) {
ctx.io().addMessageListener(TOPIC_TASK_CANCEL, new
TaskCancelMessageListener());
ctx.io().addMessageListener(TOPIC_TASK, new JobMessageListener(true));
+ ctx.internalSubscriptionProcessor().registerGlobalStateListener(this);
Review Comment:
In scope of refactoring we shouldn't change logic. It was called twice
before changes, perhaps there is a reason for this.
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/subscription/GridInternalSubscriptionProcessor.java:
##########
@@ -55,6 +56,9 @@ public class GridInternalSubscriptionProcessor extends
GridProcessorAdapter {
*/
private List<DistributedConfigurationLifecycleListener>
distributedConfigurationListeners = new ArrayList<>();
+ /** */
+ private final List<IgniteChangeGlobalStateSupport> globalStateListeners =
new ArrayList<>();
Review Comment:
Fixed
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/metastorage/persistence/DistributedMetaStorageImpl.java:
##########
@@ -279,6 +279,8 @@ public DistributedMetaStorageImpl(GridKernalContext ctx) {
DistributedMetaStorageUpdateAckMessage.class,
this::onAckMessage
);
+
+ ctx.internalSubscriptionProcessor().registerGlobalStateListener(this);
Review Comment:
Fixed
##########
modules/core/src/main/java/org/apache/ignite/internal/managers/encryption/GridEncryptionManager.java:
##########
@@ -311,6 +311,8 @@ public GridEncryptionManager(GridKernalContext ctx) {
}
});
+ ctx.internalSubscriptionProcessor().registerGlobalStateListener(this);
Review Comment:
`GridEncryptionManager` doesn't call `onKernalStart` on activation. As for
`GridTaskProcessor`, investigation is required and this activity is out of
scope of this ticket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
