Vladsz83 commented on code in PR #11391:
URL: https://github.com/apache/ignite/pull/11391#discussion_r1718555785
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotChecker.java:
##########
@@ -218,73 +221,109 @@ public <T> T readFromFile(File smf)
}
}
- /** */
- public List<SnapshotMetadata> checkLocalMetas(File snpFullPath, @Nullable
Collection<Integer> cacheGrpIds,
- @Nullable Object locNodeConsistId) {
- List<SnapshotMetadata> snpMetas = readSnapshotMetadatas(snpFullPath,
locNodeConsistId);
+ /** Launches local metas checking and waits for the result, handles
execution exceptions. */
+ public List<SnapshotMetadata> checkLocalMetasResult(File snpPath,
@Nullable Collection<Integer> grpIds, @Nullable Object locNodeCstId) {
Review Comment:
> Also use a timeout for the `get()`.
I'n afraid, user cannot pass any timeout on snapshot checking. Even
impossible to cancel it yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
