vldpyatkov commented on code in PR #4229:
URL: https://github.com/apache/ignite-3/pull/4229#discussion_r1718710656
##########
modules/raft/src/main/java/org/apache/ignite/internal/raft/server/impl/JraftServerImpl.java:
##########
@@ -729,7 +741,7 @@ public void result(Serializable res) {
};
}
});
- } catch (Exception err) {
+ } catch (Throwable err) {
Review Comment:
In the case of a no-op failure handler, this behavior would be different
from the previous.
I am not sure that is bad, but maybe we will handle the exception class only.
It is up to you.
##########
modules/raft/src/main/java/org/apache/ignite/internal/raft/server/impl/JraftServerImpl.java:
##########
@@ -663,15 +672,18 @@ public static class DelegatingStateMachine extends
StateMachineAdapter {
private final Marshaller marshaller;
+ private final FailureProcessor failureProcessor;
+
/**
* Constructor.
*
* @param listener The listener.
* @param marshaller Marshaller.
*/
- DelegatingStateMachine(RaftGroupListener listener, Marshaller
marshaller) {
+ public DelegatingStateMachine(RaftGroupListener listener, Marshaller
marshaller, FailureProcessor failureProcessor) {
this.listener = listener;
this.marshaller = marshaller;
+ this.failureProcessor = failureProcessor;
Review Comment:
Add parameter in java doc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
