skorotkov commented on code in PR #11482:
URL: https://github.com/apache/ignite/pull/11482#discussion_r1721769471
##########
modules/ducktests/src/main/java/org/apache/ignite/internal/ducktest/tests/dns_failure_test/BlockingNameService.java:
##########
@@ -71,27 +69,11 @@ private static void installJdk11() throws Exception {
System.out.println("Installed DnsBlocker as main NameService to JVM");
}
- /** Installs {@code BlockingNameService} as main {@code NameService} to
JVM8. */
Review Comment:
I think jdk8 support should be preserved in test as such, since 'master'
ducktests are supposed to work with any old ignite version. Not only with the
most recent one.
It's ok to make use jdk11 as default for testing via docker but if needed
tests should work with jdk8 as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
