tkalkirill commented on code in PR #4248:
URL: https://github.com/apache/ignite-3/pull/4248#discussion_r1722985524
##########
modules/raft-api/src/main/java/org/apache/ignite/internal/raft/configuration/RaftConfigurationSchema.java:
##########
@@ -29,13 +29,13 @@
@ConfigurationRoot(rootName = "raft", type = ConfigurationType.LOCAL)
public class RaftConfigurationSchema {
/**
- * RPC Timeout for InstallSnapshot request (in milliseconds). This is the
maximum allowed duration from sending
+ * Timeout for InstallSnapshot request (in milliseconds). This is the
maximum allowed duration from sending
* InstallSnapshot request and getting a response to it; during it, the
snapshot must be fully transferred to
* a recipient and installed.
*/
@Value(hasDefault = true)
// TODO: IGNITE-18480 - is 5 minutes a good default?
- public int rpcInstallSnapshotTimeout = 5 * 60 * 1000;
+ public int installSnapshotTimeout = 5 * 60 * 1000;
Review Comment:
Please check files with ***.adoc** and ***.conf**.
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/configuration/schema/PageMemoryCheckpointConfigurationSchema.java:
##########
@@ -26,15 +26,18 @@
*/
@Config
public class PageMemoryCheckpointConfigurationSchema {
- /** Checkpoint frequency in milliseconds. */
+ /** Interval between checkpoints in milliseconds. */
@Range(min = 0)
@Value(hasDefault = true)
- public long frequency = 180_000;
+ public long interval = 180_000;
- /** Checkpoint frequency deviation. */
+ /**
+ * Max deviation (in percent) of intervals between checkpoints. If this is
20 and {@link #interval} is 1000, then the effective
+ * checkpoint interval values will be between 900 and 1100.
+ */
@Range(min = 0, max = 100)
@Value(hasDefault = true)
- public int frequencyDeviation = 40;
+ public int intervalDeviation = 40;
Review Comment:
Please check files with ***.adoc** and ***.conf**
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/configuration/schema/VolatilePageMemoryProfileConfigurationSchema.java:
##########
@@ -46,8 +46,4 @@ public class VolatilePageMemoryProfileConfigurationSchema
extends StorageProfile
/** Maximum memory region size in bytes. */
@Value(hasDefault = true)
public long maxSize = DFLT_DATA_REGION_MAX_SIZE;
-
- /** Maximum amount of empty pages to keep in memory. */
- @Value(hasDefault = true)
- public int emptyPagesPoolSize = 100;
Review Comment:
Please check files with ***.adoc**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
