ibessonov commented on code in PR #4244:
URL: https://github.com/apache/ignite-3/pull/4244#discussion_r1724981811
##########
modules/cli/src/integrationTest/java/org/apache/ignite/internal/NodeConfig.java:
##########
@@ -44,27 +44,25 @@ public class NodeConfig {
* @return Config pattern.
*/
public static String restSslBootstrapConfig(@Nullable String ciphers) {
- return "{\n"
- + " network: {\n"
- + " port: {},\n"
- + " nodeFinder: {\n"
- + " netClusterNodes: [ {} ]\n"
- + " },\n"
- + " },\n"
- + " clientConnector.port: {} ,\n"
- + " rest: {\n"
+ return "ignite {\n"
Review Comment:
You forgot to rollback this one
##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/configuration/ItNodeConfigurationFileTest.java:
##########
@@ -57,27 +57,27 @@ public void wrongConfigurationFormat(TestInfo testInfo,
@WorkDirectory Path work
@Test
public void illegalConfigurationValueType(TestInfo testInfo,
@WorkDirectory Path workDir) {
String config =
- "{\n"
- + " rest: {\n"
- + " ssl: {\n"
- + " enabled: true,\n"
- + " clientAuth: none,\n"
- + " keyStore: {\n"
- + " path: 123\n"
- + " }\n"
- + " }\n"
- + " }\n"
- + "}";
+ "ignite {\n"
+ + " rest: {\n"
Review Comment:
Something's wrong with padding, please make it as it was
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
