ygerzhedovich commented on code in PR #4253:
URL: https://github.com/apache/ignite-3/pull/4253#discussion_r1724852263
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/ddl/DdlSqlToCommandConverter.java:
##########
@@ -630,6 +630,8 @@ private CatalogCommand convertDropIndex(IgniteSqlDropIndex
sqlCmd, PlanningConte
.build();
}
+
+
Review Comment:
redundant change
##########
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/commands/AbstractIndexCommand.java:
##########
@@ -49,6 +50,10 @@ public String indexName() {
}
private void validate() {
+ if (schemaName != null && CatalogUtils.isSystemSchema(schemaName)) {
+ throw new CatalogValidationException(format("Operations with
reserved schemas are not allowed, schema: {}", schemaName));
Review Comment:
why not `system schema`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
