lowka commented on code in PR #4251:
URL: https://github.com/apache/ignite-3/pull/4251#discussion_r1727142866
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/IgniteTypeCoercion.java:
##########
@@ -762,7 +763,10 @@ private boolean validateCoerceColumn(SqlDynamicParam
dynamicParam, RelDataType t
// TODO: https://issues.apache.org/jira/browse/IGNITE-19721 - move this
check to SqlValidator (if possible).
private void validateAssignment(SqlDynamicParam node, RelDataType
targetType, ContextType ctxType, IgniteSqlValidator validator) {
RelDataType paramType = validator.resolveDynamicParameterType(node,
targetType);
- boolean compatible = TypeUtils.typeFamiliesAreCompatible(typeFactory,
targetType, paramType);
+
+ boolean compatible = TypeUtils.typeFamiliesAreCompatible(typeFactory,
targetType, paramType)
Review Comment:
If `TypeUtils.typeFamiliesAreCompatible ` is going to used together with
`IgniteCustomAssignmentsRules` , then it is better to extract them into a
separate method that conditionally checks for `IgniteCustomAssignmentsRules `.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
