sanpwc commented on code in PR #4049:
URL: https://github.com/apache/ignite-3/pull/4049#discussion_r1728801016
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java:
##########
@@ -2917,34 +2881,32 @@ private CompletableFuture<CompletableFuture<?>>
applyUpdateAllCommand(
}
} else {
return applyCmdWithExceptionHandling(cmd, new
CompletableFuture<>())
- .thenApply(res -> {
+ .thenCompose(res -> {
UpdateCommandResult updateCommandResult =
(UpdateCommandResult) res;
- if (full &&
!updateCommandResult.isPrimaryReplicaMatch()) {
- throw new
PrimaryReplicaMissException(cmd.txId(), cmd.leaseStartTime(),
-
updateCommandResult.currentLeaseStartTime());
+ if (!updateCommandResult.isPrimaryReplicaMatch()) {
Review Comment:
Updated with:
```
/**
* Whether the command was executed successfully or failed due to
mismatch of primary replica information, i.e. lease start time that
* was sent along with the command doesn't match the one in raft updated
by handlePrimaryReplicaChangeCommand.
*
* @return Whether the command was executed successfully or failed due
to mismatch of primary replica information.
*/
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
