lowka commented on code in PR #4221:
URL: https://github.com/apache/ignite-3/pull/4221#discussion_r1730962440
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/PlannerHelper.java:
##########
@@ -343,4 +357,228 @@ static boolean hasSubQuery(SqlNode node) {
return super.visit(call);
}
}
+
+ /**
+ * Whether we can optimize a query that looks like {@code SELECT count(*)}
or not.
+ * If this method returns {@code true}, then {@link
#tryOptimizeSelectCount(IgnitePlanner, QueryTransactionContext, SqlNode)}
Review Comment:
Fixed. This method is removed as it is no longer needed.
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/PrepareServiceImpl.java:
##########
@@ -248,16 +252,20 @@ public CompletableFuture<QueryPlan> prepareAsync(
);
}
- private CompletableFuture<QueryPlan> prepareAsync0(ParsedResult
parsedResult, PlanningContext planningContext) {
+ private CompletableFuture<QueryPlan> prepareAsync0(
+ ParsedResult parsedResult,
+ PlanningContext planningContext,
+ @Nullable QueryTransactionContext txContext
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
