alievmirza commented on code in PR #4283:
URL: https://github.com/apache/ignite-3/pull/4283#discussion_r1731384659
##########
modules/raft/src/main/java/org/apache/ignite/internal/raft/RaftGroupServiceImpl.java:
##########
@@ -566,9 +567,15 @@ private <R extends NetworkMessage> CompletableFuture<R>
sendWithRetry(
* @param stopTime Stop time.
* @param fut The future.
* @param <R> Response type.
+ * @param retriesCount Retries count.
Review Comment:
I'm not sure that this is a good name, from my point of view it could be
interpreted like "how many retries will be done in the method `sendWithRetry`.
I would choose something like `retryCount` or `attemptCount`, but it is up to
you. However I would definitely improve javadoc, just `Retries count` is not
enough.
##########
modules/raft/src/main/java/org/apache/ignite/internal/raft/RaftGroupServiceImpl.java:
##########
@@ -566,9 +567,15 @@ private <R extends NetworkMessage> CompletableFuture<R>
sendWithRetry(
* @param stopTime Stop time.
* @param fut The future.
* @param <R> Response type.
+ * @param retriesCount Retries count.
Review Comment:
I'm not sure that this is a good name, from my point of view it could be
interpreted like "how many retries will be done in the method `sendWithRetry`
". I would choose something like `retryCount` or `attemptCount`, but it is up
to you. However I would definitely improve javadoc, just `Retries count` is
not enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
