kgusakov commented on code in PR #4284:
URL: https://github.com/apache/ignite-3/pull/4284#discussion_r1732583585
##########
modules/partition-replicator/src/integrationTest/java/org/apache/ignite/internal/partition/replicator/utils/TestPlacementDriver.java:
##########
@@ -81,7 +81,11 @@ public CompletableFuture<List<TokenizedAssignments>>
getAssignments(
return failedFuture(new
UnsupportedOperationException("getAssignments() is not supported in
FakePlacementDriver yet."));
}
- private CompletableFuture<ReplicaMeta> getPrimaryReplicaMeta() {
+ private CompletableFuture<ReplicaMeta>
getPrimaryReplicaMeta(ReplicationGroupId replicationGroupId) {
+ if (replicationGroupId instanceof ZonePartitionId &&
((ZonePartitionId) replicationGroupId).zoneId() == 0) {
Review Comment:
Let's name this 0 as a separate DEFAULT_ZONE_ID field
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
