Vladsz83 commented on code in PR #11467: URL: https://github.com/apache/ignite/pull/11467#discussion_r1735080602
########## modules/core/src/main/java/org/apache/ignite/internal/processors/query/schema/SchemaSqlViewManager.java: ########## @@ -0,0 +1,222 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.processors.query.schema; + +import java.io.Serializable; +import java.util.Objects; +import org.apache.ignite.IgniteCheckedException; +import org.apache.ignite.IgniteLogger; +import org.apache.ignite.internal.GridKernalContext; +import org.apache.ignite.internal.processors.cluster.IgniteChangeGlobalStateSupport; +import org.apache.ignite.internal.processors.metastorage.DistributedMetaStorage; +import org.apache.ignite.internal.processors.metastorage.DistributedMetastorageLifecycleListener; +import org.apache.ignite.internal.processors.metastorage.ReadableDistributedMetaStorage; +import org.apache.ignite.internal.util.typedef.internal.S; +import org.apache.ignite.internal.util.typedef.internal.U; +import org.apache.ignite.plugin.security.SecurityPermission; +import org.jetbrains.annotations.Nullable; + +/** + * Global schema SQL view manager. + */ +public class SchemaSqlViewManager implements IgniteChangeGlobalStateSupport { + /** Distributed metastorage key prefix. */ + private static final String SQL_VIEW_KEY_PREFIX = DistributedMetaStorage.IGNITE_INTERNAL_KEY_PREFIX + "sql.view."; + + /** Kernal context. */ + private final GridKernalContext ctx; + + /** */ + private volatile DistributedMetaStorage metastorage; + + /** Logger. */ + private final IgniteLogger log; + + /** + * Constructor. + * + * @param ctx Context. + */ + public SchemaSqlViewManager(GridKernalContext ctx) { + this.ctx = ctx; + + log = ctx.log(SchemaSqlViewManager.class); + } + + /** */ + public void start() { + ctx.internalSubscriptionProcessor().registerDistributedMetastorageListener(new DistributedMetastorageLifecycleListener() { + @Override public void onReadyForRead(ReadableDistributedMetaStorage metastorage) { + metastorage.listen(key -> key.startsWith(SQL_VIEW_KEY_PREFIX), + SchemaSqlViewManager.this::processMetastorageUpdate); + } + + @Override public void onReadyForWrite(DistributedMetaStorage metastorage) { + SchemaSqlViewManager.this.metastorage = metastorage; + } + }); + + ctx.internalSubscriptionProcessor().registerGlobalStateListener(this); + } + + /** */ + public void createView(String schemaName, String viewName, String viewSql, boolean replace) throws IgniteCheckedException { + ctx.security().authorize(SecurityPermission.SQL_VIEW_CREATE); + + if (!ctx.query().schemaManager().schemaNames().contains(schemaName)) + throw new SchemaOperationException(SchemaOperationException.CODE_SCHEMA_NOT_FOUND, schemaName); + + String key = makeKey(schemaName, viewName); + + Serializable oldVal; + Serializable newVal = new SqlView(schemaName, viewName, viewSql); + + do { + oldVal = metastorage.read(key); + + if (oldVal != null && !replace) + throw new SchemaOperationException(SchemaOperationException.CODE_VIEW_EXISTS, viewName); + } + while (!metastorage.compareAndSet(key, oldVal, newVal)); + } + + /** */ + public void dropView(String schemaName, String viewName, boolean ifExists) throws IgniteCheckedException { + ctx.security().authorize(SecurityPermission.SQL_VIEW_DROP); + + String key = makeKey(schemaName, viewName); + + Serializable oldVal; + + do { + oldVal = metastorage.read(key); + + if (oldVal == null) { + if (!ifExists) + throw new SchemaOperationException(SchemaOperationException.CODE_VIEW_NOT_FOUND, viewName); + else + return; + } + } + while (!metastorage.compareAndRemove(key, oldVal)); + } + + /** */ + public void clearSchemaViews(String schemaName) { + if (!U.isLocalNodeCoordinator(ctx.discovery())) Review Comment: Let's use `!U.isLocalNodeCoordinator(ctx.discovery())` outside -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
