lowka commented on code in PR #4256:
URL: https://github.com/apache/ignite-3/pull/4256#discussion_r1735968931
##########
modules/catalog-compaction/src/main/java/org/apache/ignite/internal/catalog/compaction/CatalogCompactionRunner.java:
##########
@@ -545,16 +566,29 @@ public void onReceived(NetworkMessage message,
ClusterNode sender, @Nullable Lon
private void handleMinimumTimesRequest(ClusterNode sender, Long
correlationId) {
HybridTimestamp lwm = lowWatermark;
- Long minRequiredTime = lwm != null ? getMinLocalTime(lwm) : null;
+ Long minRequiredTime;
+ if (lwm != null) {
+ LocalMinTime minLocalTime = getMinLocalTime(lwm);
+ if (minLocalTime != null) {
+ minRequiredTime = minLocalTime.time;
+ } else {
+ minRequiredTime = null;
+ }
+ } else {
+ minRequiredTime = null;
+ }
// We do not have local min time yet. Reply with the absolute min
time.
if (minRequiredTime == null) {
minRequiredTime = HybridTimestamp.MIN_VALUE.longValue();
}
+ Map<Integer, BitSet> availablePartitions =
buildTablePartitions(localMinTimeProvider.minTimePerPartition());
Review Comment:
This call is unnecessary. I later use `LocalMinTime::availablePartitions`
instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
