xtern commented on code in PR #4325:
URL: https://github.com/apache/ignite-3/pull/4325#discussion_r1753199259


##########
modules/catalog-compaction/README.md:
##########
@@ -1 +1,101 @@
 # Catalog compaction module
+
+> **_NOTE_** Compaction has been moved to a separate module to eliminate 
circular dependencies,
+as it requires some components that may themselves depend on the catalog 
module. Please 
+refer to the catalog's module [readme](../catalog/README.md) to see more 
details about 
+catalog service and update log.
+
+## Overview
+
+During schema changes, the catalog update log stores incremental updates. Each 
update
+increases the catalog version. Over time, the log may grow to a humongous  
size. To 
+address this, snapshotting was introduced to UpdateLog. Snapshotting means 
replacing 
+incremental updates with a snapshot.
+
+But different components can refer to a specific version of the catalog. Until 
they 
+finish their work with this version, it cannot be truncated.
+
+This module introduces 
[CatalogCompactionRunner](src/main/java/org/apache/ignite/internal/catalog/compaction/CatalogCompactionRunner.java)
+component. This component handles periodical catalog compaction, ensuring that 
dropped  versions
+of the catalog are no longer needed by any component in the cluster.
+
+## Compaction restrictions
+
+1. Catalog compaction can be performed up to the highest version (excluding) 
which activation time is less 
+   or equal to the earliest active transaction begin timestamp.
+2. Catalog must not be compacted by version which can be required to replay 
the raft log during recovery.
+3. Index building is stick with a specific catalog version. This version 
cannot be truncated until
+   the index build is complete.
+4. Rebalance is stick with a specific catalog version. This version cannot be 
truncated until the rebalance
+   is complete.
+
+## Coordinator
+
+Compaction is performed from single node (compaction coordinator) which is the 
leader
+of the metastorage group for simplicity. Therefore, when the metastorage group 
leader
+changes, the compaction coordinator also changes.
+
+The 
[ElectionListener](../metastorage/src/main/java/org/apache/ignite/internal/metastorage/impl/ElectionListener.java)
+interface was introduced to listen for metastore leader elections.
+
+## Triggering factors
+
+The process is initiated by one of the following events:
+
+1. `low watermark` has been changed (every 5 minutes by default)
+2. the compaction coordinator has been changed
+
+## Overall process description
+
+Catalog compaction consists of two main stages:
+
+1. **Replicas update**. Updates all replication groups with determined minimum 
begin
+   time among all active RW transactions in the cluster. After some time (see 
below for details)
+   these timestamps are published and become available for the next phase.
+
+2. **Compaction**. Using the timestamps published on the previous stage 
calculates

Review Comment:
   Thanks, fixed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to