sanpwc commented on code in PR #4256:
URL: https://github.com/apache/ignite-3/pull/4256#discussion_r1761388828
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/PartitionListener.java:
##########
@@ -714,10 +713,18 @@ private void
handleUpdateMinimalActiveTxTimeCommand(UpdateMinimumActiveTxBeginTi
}
long minActiveTxBeginTime0 = minActiveTxBeginTime;
+ long timestamp = cmd.timestamp();
- assert minActiveTxBeginTime0 <= cmd.timestamp() : "maxTime=" +
minActiveTxBeginTime0 + ", cmdTime=" + cmd.timestamp();
+ assert minActiveTxBeginTime0 <= timestamp : "maxTime=" +
minActiveTxBeginTime0 + ", cmdTime=" + timestamp;
- minActiveTxBeginTime = cmd.timestamp();
+ storage.flush(false).whenComplete((r, t) -> {
Review Comment:
The fact that within command processing in raft state machine we
- may switch threads
- call long running operations
- skip exception handling
smells.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
