isapego commented on code in PR #4401:
URL: https://github.com/apache/ignite-3/pull/4401#discussion_r1762625411
##########
modules/platforms/python/cpp_module/type_conversion.h:
##########
@@ -122,40 +161,162 @@ static void submit_pyobject(ignite::binary_tuple_builder
&builder, PyObject *obj
return;
}
- if (PyBool_Check(obj)) {
- bool val = (obj == Py_True);
+ if (PyObject_IsInstance(obj, py_get_module_timestamp_class())) {
+ auto double_value = PyFloat_AsDouble(obj);
+ if (PyErr_Occurred()) {
+ throw ignite::ignite_error("Can not get ticks count from a
TIMESTAMP value");
Review Comment:
It's not, I'll handle it just as a float type. Added getting an error
message from an exception where possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
