okreda1 commented on code in PR #11536:
URL: https://github.com/apache/ignite/pull/11536#discussion_r1768135803
##########
modules/ducktests/tests/checks/utils/check_ignite_spec.py:
##########
@@ -79,19 +78,10 @@ def
check_default_jvm_options__are_not_used__if_merge_with_default_is_false(serv
assert len(spec.jvm_opts) == 0
-def
check_boolean_options__go_after_default_ones_and_overwrite_them__if_passed_via_jvm_opt(service):
Review Comment:
Returned the test, tweaked it to check FlightRecorder in options
##########
modules/ducktests/tests/ignitetest/services/utils/ignite_spec.py:
##########
@@ -102,6 +102,10 @@ def __get_default_jvm_opts(self):
oom_path=os.path.join(self.service.log_dir, "out_of_mem.hprof"),
vm_error_path=os.path.join(self.service.log_dir, "hs_err_pid%p.log"))
+ if not self.service.context.globals.get(SAFEPOINT_LOGS_DISABLED,
False):
+ default_jvm_opts = merge_jvm_settings(
+ default_jvm_opts, ["-Xlog:safepoint:" +
os.path.join(self.service.log_dir, "safepoint.log")])
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
