ygerzhedovich commented on code in PR #4409:
URL: https://github.com/apache/ignite-3/pull/4409#discussion_r1771513500
##########
modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/datatypes/tests/BaseDmlDataTypeTest.java:
##########
@@ -89,19 +87,6 @@ public void testUpdateFromDynamicParam() {
.check();
}
- /**
- * Type mismatch in {@code INSERT}s {@code VALUES} with dynamic parameters.
- */
- @ParameterizedTest
Review Comment:
Why did you decide to remove the test?
##########
modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/datatypes/uuid/ItUuidDmlTest.java:
##########
@@ -17,71 +17,26 @@
package org.apache.ignite.internal.sql.engine.datatypes.uuid;
-import static org.apache.ignite.internal.lang.IgniteStringFormatter.format;
-import static
org.apache.ignite.internal.sql.engine.util.SqlTestUtils.assertThrowsSqlException;
-
import java.util.UUID;
import org.apache.ignite.internal.sql.engine.datatypes.DataTypeTestSpecs;
import
org.apache.ignite.internal.sql.engine.datatypes.tests.BaseDmlDataTypeTest;
import org.apache.ignite.internal.sql.engine.datatypes.tests.DataTypeTestSpec;
import org.apache.ignite.internal.sql.engine.datatypes.tests.TestTypeArguments;
import org.apache.ignite.internal.sql.engine.type.UuidType;
-import org.apache.ignite.lang.ErrorGroups.Sql;
-import org.junit.jupiter.params.ParameterizedTest;
-import org.junit.jupiter.params.provider.MethodSource;
/**
* Tests for DML statements for {@link UuidType UUID data type}.
*/
public class ItUuidDmlTest extends BaseDmlDataTypeTest<UUID> {
- /** {@code INSERT} with dynamic parameters is not allowed for compatible
types. */
- @ParameterizedTest
- @MethodSource("convertedFrom")
- public void
testInsertFromDynamicParameterFromConvertible(TestTypeArguments arguments) {
Review Comment:
Do we have another similar test for UUID?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
