korlov42 commented on code in PR #4409:
URL: https://github.com/apache/ignite-3/pull/4409#discussion_r1773360519
##########
modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/datatypes/tests/BaseDmlDataTypeTest.java:
##########
@@ -89,19 +87,6 @@ public void testUpdateFromDynamicParam() {
.check();
}
- /**
- * Type mismatch in {@code INSERT}s {@code VALUES} with dynamic parameters.
- */
- @ParameterizedTest
Review Comment:
mostly because configuration of these test cases is overcomplicated.
Besides, there is no need to make it special only for certain types. Exhaustive
validation test coverage is made by
`DifferentFamiliesInsertSourcesCoercionTest` (I've added validation of
multi-tuple insert, see changes in `DifferentFamiliesInsertSourcesCoercionTest`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
